Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update readme demo #333

Merged
merged 1 commit into from
Apr 27, 2023
Merged

update readme demo #333

merged 1 commit into from
Apr 27, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

update the demo video in readme.md

@SparkYuan SparkYuan requested a review from liu-hm19 April 27, 2023 06:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4816788140

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 71.982%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
Totals Coverage Status
Change from base Build 4782325469: 0.09%
Covered Lines: 4776
Relevant Lines: 6635
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkYuan SparkYuan merged commit 74d50db into KusionStack:main Apr 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2023
@SparkYuan SparkYuan deleted the update-readme-demo branch June 26, 2023 07:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SparkYuan @coveralls @liu-hm19