Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: dedup pint apply/destroy dag node executing error #342

Merged
merged 1 commit into from
May 11, 2023
Merged

bugfix: dedup pint apply/destroy dag node executing error #342

merged 1 commit into from
May 11, 2023

Conversation

howieyuen
Copy link
Collaborator

close: #276

@howieyuen howieyuen requested a review from liu-hm19 May 11, 2023 08:46
@howieyuen howieyuen enabled auto-merge (squash) May 11, 2023 08:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4945870317

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 71.869%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/destroy/options.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
Totals Coverage Status
Change from base Build 4936473422: 0.0%
Covered Lines: 4854
Relevant Lines: 6754
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howieyuen howieyuen merged commit 074a213 into KusionStack:main May 11, 2023
@howieyuen howieyuen deleted the dedup-err branch May 11, 2023 08:56
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicated error message output when failed to destroy resources
3 participants
@howieyuen @coveralls @liu-hm19