Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support init with specified template #343

Merged
merged 3 commits into from
May 12, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

feature

What this PR does / why we need it:

support specifying template when kusion init. By using flag --template-name, you can specify the template you want to use, prompt will not exist.

Which issue(s) this PR fixes:

Fixes #265

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., design docs, usage docs, etc.:

None

@coveralls
Copy link

coveralls commented May 11, 2023

Pull Request Test Coverage Report for Build 4955885078

  • 17 of 34 (50.0%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 71.87%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/init/options.go 14 31 45.16%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/ls/types.go 5 83.82%
Totals Coverage Status
Change from base Build 4945960841: 0.03%
Covered Lines: 4862
Relevant Lines: 6765

💛 - Coveralls

@healthjyk healthjyk changed the title Init template support init with specified template May 11, 2023
pkg/cmd/init/options.go Show resolved Hide resolved
pkg/cmd/init/options.go Outdated Show resolved Hide resolved
pkg/cmd/init/options.go Show resolved Hide resolved
pkg/cmd/init/options.go Outdated Show resolved Hide resolved
pkg/cmd/init/options.go Show resolved Hide resolved
pkg/cmd/init/options.go Outdated Show resolved Hide resolved
amyXia1994
amyXia1994 previously approved these changes May 12, 2023
Copy link
Contributor

@amyXia1994 amyXia1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@howieyuen howieyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@howieyuen howieyuen merged commit 650fb02 into KusionStack:main May 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
@healthjyk healthjyk deleted the init-template branch December 27, 2023 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Kusion provides API for integration tools
4 participants