Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade pterm to achieve a live-updated progressbar #345

Merged
merged 1 commit into from
May 12, 2023
Merged

chore: upgrade pterm to achieve a live-updated progressbar #345

merged 1 commit into from
May 12, 2023

Conversation

howieyuen
Copy link
Collaborator

close: #294
close: #313

ref: pterm/pterm#460

@howieyuen howieyuen requested a review from liu-hm19 May 12, 2023 03:23
@howieyuen howieyuen enabled auto-merge (squash) May 12, 2023 03:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4954891664

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.07%) to 71.913%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
Totals Coverage Status
Change from base Build 4945960841: 0.07%
Covered Lines: 4857
Relevant Lines: 6754
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 86d50b0 into KusionStack:main May 12, 2023
@howieyuen howieyuen deleted the progressbar branch May 12, 2023 06:23
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@howieyuen @coveralls @liu-hm19