-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support kusion preview --ouput json #346
Conversation
…tion/models.Changes when preview succeeded
Pull Request Test Coverage Report for Build 4988781634
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@amyXia1994 If there is no resource in the planned spec, there will be an empty output when --output json, you may need a judgement before json unmarshal. For the case without --output json, there is a hint, but still with successful preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
feature
What this PR does / why we need it:
when using cmd kusion preview, there is no way to get the pure preview result, cause there is prompt. Support --output json to print the preview result without any unnecessary prompt when succeeded.
Which issue(s) this PR fixes:
Fixes #265
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: