Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine no-style and remove no-prompt command option #367

Conversation

liu-hm19
Copy link
Contributor

@liu-hm19 liu-hm19 commented Jul 7, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR refines "no-style" command line option.

Which issue(s) this PR fixes:

Fixes #366

Special notes for your reviewer:

This PR removes "no-prompt" command line option.

Does this PR introduce a user-facing change?

Add "no-style" option for kusion compile for better third-party integration while remove the "no-prompt" option. 

Additional documentation e.g., design docs, usage docs, etc.:


…r compiling and disable the color of error message when no-style is true
@coveralls
Copy link

coveralls commented Jul 7, 2023

Pull Request Test Coverage Report for Build 5539977810

  • 11 of 11 (100.0%) changed or added relevant lines in 4 files are covered.
  • 58 unchanged lines in 9 files lost coverage.
  • Overall coverage increased (+0.4%) to 72.183%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/init/init.go 2 90.63%
pkg/cmd/cmd.go 4 34.52%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/cmd/diff/diff.go 6 92.21%
pkg/engine/operation/parser/parser.go 6 74.36%
pkg/engine/operation/apply.go 7 70.21%
pkg/cmd/apply/options.go 8 74.21%
pkg/cmd/destroy/options.go 10 84.08%
pkg/util/i18n/i18n.go 11 86.08%
Totals Coverage Status
Change from base Build 5386655820: 0.4%
Covered Lines: 4933
Relevant Lines: 6834

💛 - Coveralls

@liu-hm19
Copy link
Contributor Author

liu-hm19 commented Jul 7, 2023

Here are some cmd examples after the optimization:
image
image

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 5f6e0f9 into KusionStack:main Jul 13, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize the display of plain text output of kusion cmd for better integration with other systems
3 participants