Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: normalize some annotations #430

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

cleanup

What this PR does / why we need it:

normalize annotations

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

Additional documentation e.g., design docs, usage docs, etc.:

None

@coveralls
Copy link

coveralls commented Aug 3, 2023

Pull Request Test Coverage Report for Build 5751106857

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 29 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 72.607%

Files with Coverage Reduction New Missed Lines %
pkg/engine/backend/backend.go 1 60.0%
pkg/cmd/preview/options.go 12 84.31%
pkg/generator/kcl/kcl_generator.go 16 80.92%
Totals Coverage Status
Change from base Build 5678670143: 0.2%
Covered Lines: 5113
Relevant Lines: 7042

💛 - Coveralls

@healthjyk healthjyk changed the title normalize some annotations style: normalize some annotations Aug 3, 2023
zh_CN.po~ Outdated Show resolved Hide resolved
@adohe
Copy link
Contributor

adohe commented Aug 4, 2023

please squash before we can merge.

@healthjyk healthjyk enabled auto-merge (squash) August 4, 2023 03:36
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@healthjyk healthjyk merged commit 464df41 into KusionStack:main Aug 7, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
@healthjyk healthjyk deleted the normalize-annotation branch December 27, 2023 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants