feat: add database generator #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-hm19
requested review from
elliotxx,
panshuai-ps,
SparkYuan,
adohe and
ffforest
liu-hm19
force-pushed
the
feat/add-database-generator
branch
2 times, most recently
from
b228a82
to
ac03b6c
Compare
ffforest
reviewed
Aug 21, 2023
pkg/generator/appconfiguration/generators/components_generator.go
Outdated
Show resolved
Hide resolved
liu-hm19
force-pushed
the
feat/add-database-generator
branch
from
ac03b6c
to
5b17acf
Compare
Pull Request Test Coverage Report for Build 5999938792
💛 - Coveralls |
liu-hm19
force-pushed
the
feat/add-database-generator
branch
2 times, most recently
from
33b2b97
to
6e5b2b5
Compare
SparkYuan
reviewed
Aug 29, 2023
pkg/generator/appconfiguration/generator/accessories/database/alicloud_rds.go
Outdated
Show resolved
Hide resolved
pkg/generator/appconfiguration/generator/accessories/database/database_generator.go
Outdated
Show resolved
Hide resolved
adohe
pushed a commit
to KusionStack/catalog
that referenced
this pull request
Aug 29, 2023
<!-- Thank you for contributing to Catalog!
Note:
1. With pull requests:
- Open your pull request against "mainb
- Your pull request should have no more than three commits, if not you
should squash them.
- It should pass all tests in the available continuous integration
systems such as GitHub Actions.
- You should add/modify tests to cover your proposed code changes.
- If your pull request contains a new feature, please document it on the
README.
2. Please create an issue first to describe the problem.
We recommend that link the issue with the PR in the following question.
For more info, check https://kusionstack.io/docs/governance/contribute/
-->
## What type of PR is this?
<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind chore
-->
/kind feature
## What this PR does / why we need it:
This PR adds support for database accessory which defines the relational
database service (rds) provided by a specified cloud vendor.
## Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related
issues/tests in a comment and do not use `Fixes`_*
-->
## Special notes for your reviewer:
The implementation of Database Generator can be found at [feat: add
database generator](KusionStack/kusion#435)
### Does this PR introduce a user-facing change?
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires
additional action from users switching to the new release, include the
string "action required".
-->
```release-note
```
### Additional documentation e.g., design docs, usage docs, etc.:
<!--
Please use the following format for linking documentation:
- [Design]: <link>
- [Usage]: <link>
- [Other doc]: <link>
-->
```docs
```
|
@liu-hm19 please resolve conflicts before we can merge this PR. |
liu-hm19
force-pushed
the
feat/add-database-generator
branch
from
b29dbeb
to
67bcc8f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds database generator.
Which issue(s) this PR fixes:
Fixes #380 & #381
Special notes for your reviewer:
An example of creating an alicloud rds is shown below:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: