Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove mandatory validation of settings.yaml during kusion compile #448

Merged
merged 6 commits into from
Aug 10, 2023
Merged

feat: remove mandatory validation of settings.yaml during kusion compile #448

merged 6 commits into from
Aug 10, 2023

Conversation

panshuai-ps
Copy link
Contributor

@panshuai-ps panshuai-ps commented Aug 9, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Remove mandatory validation of settings.yaml during kusion compile.

Which issue(s) this PR fixes:

Fixes #440

@panshuai-ps panshuai-ps added the kind/feature Categorizes issue or PR as related to a new feature label Aug 9, 2023
@panshuai-ps panshuai-ps added this to the 0.9.0 milestone Aug 9, 2023
@panshuai-ps panshuai-ps self-assigned this Aug 9, 2023
@panshuai-ps panshuai-ps changed the title feat: remove mandatorily validate settings.yml during kusion compile feat: remove mandatorily validate settings.yaml during kusion compile Aug 9, 2023
@panshuai-ps panshuai-ps changed the title feat: remove mandatorily validate settings.yaml during kusion compile feat: remove validating settings.yaml mandatorily during kusion compile Aug 9, 2023
@panshuai-ps panshuai-ps changed the title feat: remove validating settings.yaml mandatorily during kusion compile feat: remove mandatory validation of settings.yaml during kusion compile Aug 9, 2023
healthjyk
healthjyk previously approved these changes Aug 10, 2023
pkg/cmd/compile/options.go Show resolved Hide resolved
pkg/cmd/compile/options_test.go Show resolved Hide resolved
@healthjyk healthjyk merged commit 67c26ef into KusionStack:main Aug 10, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2023
@panshuai-ps panshuai-ps deleted the add-job-module-remove-validate-settings-yaml branch August 10, 2023 11:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mandatory validation of settings.yaml during kusion compile
2 participants