Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use mock as the function name instead of monkey #449

Merged
merged 1 commit into from
Aug 10, 2023
Merged

refactor: Use mock as the function name instead of monkey #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions pkg/cmd/preview/options_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ var (
func Test_preview(t *testing.T) {
stateStorage := &local.FileSystemState{Path: filepath.Join("", local.KusionState)}
t.Run("preview success", func(t *testing.T) {
m := monkeyPatchOperationPreview()
m := mockOperationPreview()
defer m.UnPatch()

o := NewPreviewOptions()
Expand All @@ -72,7 +72,7 @@ func TestPreviewOptions_Run(t *testing.T) {
})

t.Run("compile failed", func(t *testing.T) {
m := monkeyPatchDetectProjectAndStack()
m := mockDetectProjectAndStack()
defer m.UnPatch()

o := NewPreviewOptions()
Expand All @@ -82,9 +82,9 @@ func TestPreviewOptions_Run(t *testing.T) {
})

t.Run("no changes", func(t *testing.T) {
m1 := monkeyPatchDetectProjectAndStack()
m2 := monkeyPatchGenerateSpecWithSpinner()
m3 := monkeyPatchNewKubernetesRuntime()
m1 := mockDetectProjectAndStack()
m2 := mockPatchGenerateSpecWithSpinner()
m3 := mockNewKubernetesRuntime()
defer m1.UnPatch()
defer m2.UnPatch()
defer m3.UnPatch()
Expand All @@ -96,11 +96,11 @@ func TestPreviewOptions_Run(t *testing.T) {
})

t.Run("detail is true", func(t *testing.T) {
m1 := monkeyPatchDetectProjectAndStack()
m2 := monkeyPatchGenerateSpecWithSpinner()
m3 := monkeyPatchNewKubernetesRuntime()
m4 := monkeyPatchOperationPreview()
m5 := monkeyPatchPromptDetail("")
m1 := mockDetectProjectAndStack()
m2 := mockPatchGenerateSpecWithSpinner()
m3 := mockNewKubernetesRuntime()
m4 := mockOperationPreview()
m5 := mockPromptDetail("")
defer m1.UnPatch()
defer m2.UnPatch()
defer m3.UnPatch()
Expand All @@ -114,11 +114,11 @@ func TestPreviewOptions_Run(t *testing.T) {
})

t.Run("json output is true", func(t *testing.T) {
m1 := monkeyPatchDetectProjectAndStack()
m2 := monkeyPatchGenerateSpec()
m3 := monkeyPatchNewKubernetesRuntime()
m4 := monkeyPatchOperationPreview()
m5 := monkeyPatchPromptDetail("")
m1 := mockDetectProjectAndStack()
m2 := mockGenerateSpec()
m3 := mockNewKubernetesRuntime()
m4 := mockOperationPreview()
m5 := mockPromptDetail("")
defer m1.UnPatch()
defer m2.UnPatch()
defer m3.UnPatch()
Expand All @@ -132,11 +132,11 @@ func TestPreviewOptions_Run(t *testing.T) {
})

t.Run("no style is true", func(t *testing.T) {
m1 := monkeyPatchDetectProjectAndStack()
m2 := monkeyPatchGenerateSpecWithSpinner()
m3 := monkeyPatchNewKubernetesRuntime()
m4 := monkeyPatchOperationPreview()
m5 := monkeyPatchPromptDetail("")
m1 := mockDetectProjectAndStack()
m2 := mockPatchGenerateSpecWithSpinner()
m3 := mockNewKubernetesRuntime()
m4 := mockOperationPreview()
m5 := mockPromptDetail("")
defer m1.UnPatch()
defer m2.UnPatch()
defer m3.UnPatch()
Expand Down Expand Up @@ -184,7 +184,7 @@ func (f *fooRuntime) Watch(ctx context.Context, request *runtime.WatchRequest) *
return nil
}

func monkeyPatchOperationPreview() *mockey.Mocker {
func mockOperationPreview() *mockey.Mocker {
return mockey.Mock((*operation.PreviewOperation).Preview).To(func(
*operation.PreviewOperation,
*operation.PreviewRequest,
Expand Down Expand Up @@ -229,15 +229,15 @@ func newSA(name string) models.Resource {
}
}

func monkeyPatchDetectProjectAndStack() *mockey.Mocker {
func mockDetectProjectAndStack() *mockey.Mocker {
return mockey.Mock(projectstack.DetectProjectAndStack).To(func(stackDir string) (*projectstack.Project, *projectstack.Stack, error) {
project.Path = stackDir
stack.Path = stackDir
return project, stack, nil
}).Build()
}

func monkeyPatchGenerateSpec() *mockey.Mocker {
func mockGenerateSpec() *mockey.Mocker {
return mockey.Mock(spec.GenerateSpec).To(func(
o *generator.Options,
project *projectstack.Project,
Expand All @@ -247,7 +247,7 @@ func monkeyPatchGenerateSpec() *mockey.Mocker {
}).Build()
}

func monkeyPatchGenerateSpecWithSpinner() *mockey.Mocker {
func mockPatchGenerateSpecWithSpinner() *mockey.Mocker {
return mockey.Mock(spec.GenerateSpecWithSpinner).To(func(
o *generator.Options,
project *projectstack.Project,
Expand All @@ -257,13 +257,13 @@ func monkeyPatchGenerateSpecWithSpinner() *mockey.Mocker {
}).Build()
}

func monkeyPatchNewKubernetesRuntime() *mockey.Mocker {
func mockNewKubernetesRuntime() *mockey.Mocker {
return mockey.Mock(kubernetes.NewKubernetesRuntime).To(func() (runtime.Runtime, error) {
return &fooRuntime{}, nil
}).Build()
}

func monkeyPatchPromptDetail(input string) *mockey.Mocker {
func mockPromptDetail(input string) *mockey.Mocker {
return mockey.Mock((*opsmodels.ChangeOrder).PromptDetails).To(func(co *opsmodels.ChangeOrder) (string, error) {
return input, nil
}).Build()
Expand Down
Loading