Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify the generators to adapt to the new model's adjustments #453

Merged
merged 1 commit into from
Aug 14, 2023
Merged

feat: modify the generators to adapt to the new model's adjustments #453

merged 1 commit into from
Aug 14, 2023

Conversation

elliotxx
Copy link
Contributor

@elliotxx elliotxx commented Aug 14, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Modify the go model of AppConfiguration, generators to adapt to the new model's adjustments.

New model:

https://github.com/KusionStack/catalog/blob/main/models/schema/v1/app_configuration.k

@elliotxx elliotxx self-assigned this Aug 14, 2023
@elliotxx elliotxx added this to the 0.9.0 milestone Aug 14, 2023
@elliotxx elliotxx changed the title feat: adapt new model adjusts [WIP] feat: adapt new model adjusts Aug 14, 2023
@elliotxx elliotxx changed the title [WIP] feat: adapt new model adjusts [WIP] feat: modify the generators to adapt to the new model's adjustments Aug 14, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5853975158

  • 0 of 7 (0.0%) changed or added relevant lines in 1 file are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.5%) to 72.092%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/spec/generator.go 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 78.21%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/cmd/apply/options.go 7 71.92%
Totals Coverage Status
Change from base Build 5821643288: 1.5%
Covered Lines: 5107
Relevant Lines: 7084
💛 - Coveralls

@elliotxx elliotxx changed the title [WIP] feat: modify the generators to adapt to the new model's adjustments feat: modify the generators to adapt to the new model's adjustments Aug 14, 2023
@elliotxx elliotxx enabled auto-merge (squash) August 14, 2023 10:03
SparkYuan
SparkYuan approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, it looks good to me

@elliotxx elliotxx merged commit 8e06f7f into KusionStack:main Aug 14, 2023
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2023
@elliotxx elliotxx linked an issue Aug 21, 2023 that may be closed by this pull request
Model: New model in catalog of generator adaptation #470
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@ffforest ffforest Awaiting requested review from ffforest

@panshuai-ps panshuai-ps Awaiting requested review from panshuai-ps

@healthjyk healthjyk Awaiting requested review from healthjyk

@adohe adohe Awaiting requested review from adohe

@liu-hm19 liu-hm19 Awaiting requested review from liu-hm19

Assignees

@elliotxx elliotxx

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Model: New model in catalog of generator adaptation
3 participants
@elliotxx @coveralls @SparkYuan