Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use generic optimization code #455

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

elliotxx
Copy link
Contributor

@elliotxx elliotxx commented Aug 15, 2023

What type of PR is this?

/kind refactor

What this PR does / why we need it:

Use generic optimization code:

  • ForeachOrderedApps / ForeachOrderedContainers => ForeachOrdered
  • Int32Ptr => IntPtr

@elliotxx elliotxx force-pushed the use-generic-optimization-code branch from 8d76703 to e26e26e Compare August 15, 2023 03:41
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elliotxx elliotxx merged commit 4a8eb1e into KusionStack:main Aug 15, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants