Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing labels and annotations injection logic #457

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

elliotxx
Copy link
Contributor

@elliotxx elliotxx commented Aug 16, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • Fix missing labels and annotations injection logic
  • Fix some typo

@elliotxx elliotxx enabled auto-merge (squash) August 16, 2023 07:05
@elliotxx elliotxx self-assigned this Aug 16, 2023
@elliotxx elliotxx added this to the 0.9.0 milestone Aug 16, 2023
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elliotxx elliotxx merged commit 7839d55 into KusionStack:main Aug 16, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model: AppConfiguration model supports custom and default labels and annotations
2 participants