Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the CollaSet generator #463

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Aug 18, 2023

…follow the go naming convention

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: add the CollaSet generator and rename some workload structs to follow the go naming convention

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan changed the title feat: add the CollaSet generator and rename some workload structs to follow the go naming convention feat: add the CollaSet generator Aug 18, 2023
@SparkYuan SparkYuan enabled auto-merge (squash) August 18, 2023 03:59
@SparkYuan SparkYuan enabled auto-merge (squash) August 18, 2023 04:00
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5899614543

  • 68 of 99 (68.69%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 70.849%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/spec/generator.go 1 2 50.0%
pkg/generator/appconfiguration/generator/workload/job_generator.go 0 2 0.0%
pkg/generator/appconfiguration/generator/workload/workload_generator.go 0 3 0.0%
pkg/models/appconfiguration/workload/workload.go 22 34 64.71%
pkg/generator/appconfiguration/generator/workload/service_generator.go 43 56 76.79%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/spec/generator.go 1 50.59%
Totals Coverage Status
Change from base Build 5898634175: -1.1%
Covered Lines: 5296
Relevant Lines: 7475

💛 - Coveralls

Copy link
Contributor

@panshuai-ps panshuai-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit ced6793 into KusionStack:main Aug 18, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants