Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support watching the collaset #464

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Aug 18, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: support watching the collaset

Which issue(s) this PR fixes:

Fixes #438

Special notes for your reviewer:

ignore some test files temporary due to the strange coveralls test coverage computing rules

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Aug 18, 2023

Pull Request Test Coverage Report for Build 5902869706

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.2%) to 70.622%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 71.92%
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 5899830919: -0.2%
Covered Lines: 5279
Relevant Lines: 7475

💛 - Coveralls

Copy link
Contributor

@panshuai-ps panshuai-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 1132767 into KusionStack:main Aug 21, 2023
6 checks passed
Copy link
Contributor

@panshuai-ps panshuai-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support watching KafeD workload resources
3 participants