Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: release action for macos-m1 and kcl-plugin #47

Merged
merged 6 commits into from
May 25, 2022
Merged

fix: release action for macos-m1 and kcl-plugin #47

merged 6 commits into from
May 25, 2022

Conversation

chai2010
Copy link
Contributor

  • update kclvm-Go to v0.4.2-alpha4
  • fix: Go generate for pkg/version
  • fix: release action install kcl-plugin

@coveralls
Copy link

coveralls commented May 25, 2022 •
edited

Pull Request Test Coverage Report for Build 2382329114

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 77.212%
Totals Coverage Status
Change from base Build 2369398268: 0.04%
Covered Lines: 3761
Relevant Lines: 4871
💛 - Coveralls

@chai2010 chai2010 changed the title WIP: fix: release action for macos-m1 and kcl-plugin fix: release action for macos-m1 and kcl-plugin May 25, 2022
elliotxx
elliotxx approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Peefy
Peefy approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 28a545b into KusionStack:main May 25, 2022
@elliotxx elliotxx linked an issue Jun 6, 2022 that may be closed by this pull request
Go mock selection #59
Closed
@elliotxx elliotxx removed a link to an issue Jun 6, 2022
Go mock selection #59
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@Peefy Peefy Peefy approved these changes

@howieyuen howieyuen Awaiting requested review from howieyuen

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

@markliby markliby Awaiting requested review from markliby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chai2010 @coveralls @elliotxx @Peefy