-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support some magic env parsers #473
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliotxx
requested review from
SparkYuan,
ffforest,
panshuai-ps,
healthjyk,
adohe and
liu-hm19
August 21, 2023 04:42
elliotxx
changed the title
feat: support magic env parser
feat: support some magic env parsers
Aug 21, 2023
elliotxx
changed the title
feat: support some magic env parsers
[WIP] feat: support some magic env parsers
Aug 21, 2023
elliotxx
changed the title
[WIP] feat: support some magic env parsers
feat: support some magic env parsers
Aug 21, 2023
Pull Request Test Coverage Report for Build 5924577087
💛 - Coveralls |
SparkYuan
reviewed
Aug 21, 2023
pkg/generator/appconfiguration/generator/workload/magic_env_var.go
Outdated
Show resolved
Hide resolved
pkg/generator/appconfiguration/generator/workload/magic_env_var.go
Outdated
Show resolved
Hide resolved
pkg/generator/appconfiguration/generator/workload/magic_env_var.go
Outdated
Show resolved
Hide resolved
elliotxx
force-pushed
the
support-magic-env-parser
branch
from
August 21, 2023 12:22
3d8f15f
to
e5e6a7c
Compare
SparkYuan
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support some magic env parsers:
SecretMagicEnvParser
RawMagicEnvParser
And, add corresponding unit tests.