feat: support creating files with configmap in container #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liu-hm19
requested review from
SparkYuan,
elliotxx,
ffforest,
panshuai-ps,
healthjyk and
adohe
Pull Request Test Coverage Report for Build 6007674666
💛 - Coveralls |
SparkYuan
reviewed
Aug 22, 2023
pkg/generator/appconfiguration/generator/workload/workload_generator.go
Outdated
Show resolved
Hide resolved
pkg/generator/appconfiguration/generator/workload/workload_generator_test.go
Outdated
Show resolved
Hide resolved
pkg/generator/appconfiguration/generator/workload/service_generator.go
Outdated
Show resolved
Hide resolved
liu-hm19
force-pushed
the
feat/support-create-file-with-configmap
branch
2 times, most recently
from
3c41825
to
f083a4f
Compare
liu-hm19
force-pushed
the
feat/support-create-file-with-configmap
branch
from
f083a4f
to
fdc7e42
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds support for creating files with ConfigMap in workload container.
Which issue(s) this PR fixes:
Fixes #379
Special notes for your reviewer:
An example of creating files with ConfigMap in the container is shown below:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: