Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lifecycle type and encoding/decoding support #491

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Aug 24, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

update Container model add lifecycle types and encoding/decoding support.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Aug 24, 2023
@adohe adohe self-assigned this Aug 24, 2023
@coveralls
Copy link

coveralls commented Aug 24, 2023

Pull Request Test Coverage Report for Build 5959404527

  • 83 of 95 (87.37%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 74.202%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/models/appconfiguration/workload/container/container.go 83 95 87.37%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/engine/operation/parser/parser.go 3 78.21%
pkg/cmd/apply/options.go 7 71.92%
Totals Coverage Status
Change from base Build 5949661358: -0.01%
Covered Lines: 5813
Relevant Lines: 7834

💛 - Coveralls

@adohe adohe requested review from elliotxx and removed request for Eikykun August 24, 2023 04:09
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 805de93 into KusionStack:main Aug 24, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
@adohe adohe deleted the update_base_model branch January 8, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants