Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace cmd arguments from string array to map #492

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind refactor

What this PR does / why we need it:

refactor: replace cmd arguments from string array to map and change struct names to follow go naming conventions

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 5960884119

  • 81 of 82 (98.78%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.09%) to 74.227%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/compile/options.go 7 8 87.5%
Totals Coverage Status
Change from base Build 5960466527: 0.09%
Covered Lines: 5809
Relevant Lines: 7826

💛 - Coveralls

Copy link
Contributor

@panshuai-ps panshuai-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe added this to the 0.9.0 milestone Aug 24, 2023
@adohe adohe added the kind/optimization Code optimization label Aug 24, 2023
@adohe adohe merged commit 5fb4e61 into KusionStack:main Aug 24, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants