Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: upgrade manifest to spec #50

Merged
merged 1 commit into from
May 26, 2022
Merged

engine: upgrade manifest to spec #50

merged 1 commit into from
May 26, 2022

Conversation

SparkYuan
Copy link
Member

  • With pull requests:
    • Open your pull request against main
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@coveralls
Copy link

coveralls commented May 25, 2022 •
edited

Pull Request Test Coverage Report for Build 2383330852

  • 28 of 34 (82.35%) changed or added relevant lines in 15 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 77.123%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/compile/compile.go 0 1 0.0%
pkg/engine/operation/delete_resource_parser.go 2 3 66.67%
pkg/engine/operation/diff.go 0 1 0.0%
pkg/engine/operation/resource_node.go 4 5 80.0%
pkg/engine/operation/manifest_parser.go 3 5 60.0%
Totals Coverage Status
Change from base Build 2382950653: -0.05%
Covered Lines: 3742
Relevant Lines: 4852
💛 - Coveralls

elliotxx
elliotxx approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

howieyuen
howieyuen approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@howieyuen howieyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 28b4f93 into main May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliotxx elliotxx elliotxx approved these changes

@howieyuen howieyuen howieyuen approved these changes

@markliby markliby Awaiting requested review from markliby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SparkYuan @coveralls @elliotxx @howieyuen