Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update scaffold template with kpm #505

Merged
merged 8 commits into from
Sep 7, 2023
Merged

feat: update scaffold template with kpm #505

merged 8 commits into from
Sep 7, 2023

Conversation

elliotxx
Copy link
Contributor

@elliotxx elliotxx commented Sep 5, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update scaffold template with kpm.

Demo:

2023-09-05.20.16.28.mov

@elliotxx elliotxx changed the title feat: update scaffold template with kpm [WIP] feat: update scaffold template with kpm Sep 5, 2023
@elliotxx elliotxx self-assigned this Sep 5, 2023
@elliotxx elliotxx added kind/feature Categorizes issue or PR as related to a new feature area/cli labels Sep 5, 2023
@elliotxx elliotxx added this to the 0.9.0 milestone Sep 5, 2023
@elliotxx elliotxx linked an issue Sep 5, 2023 that may be closed by this pull request
kusion init provides a new way to collect template params value with specified CLI flag #72
Closed
@elliotxx elliotxx removed a link to an issue Sep 5, 2023
kusion init provides a new way to collect template params value with specified CLI flag #72
Closed
@elliotxx elliotxx linked an issue Sep 5, 2023 that may be closed by this pull request
Feature: update Kusion init template with the new AppConfig model #468
Closed
@elliotxx elliotxx changed the title [WIP] feat: update scaffold template with kpm feat: update scaffold template with kpm Sep 6, 2023
@ffforest ffforest linked an issue Sep 6, 2023 that may be closed by this pull request
Toolchain: Decouple Kusion from model definition #403
Closed
@healthjyk
Copy link
Contributor

If kpm is in use, does kcl still in used?
Does the installation script need to get update? including shell/brew/scoop?
Does kpm work under windows?

ffforest
ffforest approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@ffforest ffforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 8a67928 into KusionStack:main Sep 7, 2023
7 of 8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2023
@elliotxx
Copy link
Contributor Author

elliotxx commented Sep 7, 2023 •
edited

If kpm is in use, does kcl still in used? Does the installation script need to get update? including shell/brew/scoop? Does kpm work under windows?

@healthjyk Prioritize the use of kpm, if it is not available, kusion will fallback to kcl.
I integrated kpm through kcl-go package, so no need to modify the installation script.
kpm can work normally in the window.
Relax, baby~

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ffforest ffforest ffforest approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

@Peefy Peefy Awaiting requested review from Peefy

@howieyuen howieyuen Awaiting requested review from howieyuen

@panshuai-ps panshuai-ps Awaiting requested review from panshuai-ps

@healthjyk healthjyk Awaiting requested review from healthjyk

@zong-zhe zong-zhe Awaiting requested review from zong-zhe

@adohe adohe Awaiting requested review from adohe

@liu-hm19 liu-hm19 Awaiting requested review from liu-hm19

Assignees

@elliotxx elliotxx

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
0.9.0
4 participants
@elliotxx @healthjyk @ffforest @SparkYuan