Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set host to empty when url parse get localhost or 127.0.0.1 #512

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Sep 6, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

set probe http action path to empty when url parse resolve localhost

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added kind/bug Something isn't working area/cli labels Sep 6, 2023
@adohe adohe added this to the 0.9.0 milestone Sep 6, 2023
@adohe adohe self-assigned this Sep 6, 2023
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit d273f94 into KusionStack:main Sep 6, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2023
@adohe adohe deleted the fix_probe_generator branch January 8, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants