Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump yaml version to v3.0.0 #52

Merged
merged 1 commit into from
May 26, 2022
Merged

chore: bump yaml version to v3.0.0 #52

merged 1 commit into from
May 26, 2022

Conversation

elliotxx
Copy link
Contributor

@elliotxx elliotxx commented May 26, 2022 •
edited

Purpose:

  • bump yaml.v3 version from v3.0.0-20220512140231-539c8e751b99 to v3.0.0
    image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2391124786

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 77.185%
Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/destroy/options.go 7 83.41%
Totals Coverage Status
Change from base Build 2388449993: 0.04%
Covered Lines: 3745
Relevant Lines: 4852
💛 - Coveralls

@elliotxx elliotxx requested review from chai2010 and Peefy May 26, 2022 14:15
Peefy
Peefy approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chai2010
chai2010 approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliotxx elliotxx merged commit c63764d into main May 26, 2022
@SparkYuan SparkYuan deleted the bump-yaml-version-to-v3.0.0 branch May 27, 2022 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chai2010 chai2010 chai2010 approved these changes

@Peefy Peefy Peefy approved these changes

@howieyuen howieyuen Awaiting requested review from howieyuen

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

@markliby markliby Awaiting requested review from markliby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@elliotxx @coveralls @chai2010 @Peefy