Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix aws database generator #542

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes some bugs for aws database generator.

Which issue(s) this PR fixes:

Fixes #540

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

Pull Request Test Coverage Report for Build 6170618027

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 74.045%

Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 6157756035: -0.06%
Covered Lines: 6259
Relevant Lines: 8453

💛 - Coveralls

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adohe adohe merged commit 7bf3c1b into KusionStack:main Sep 14, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: fix database generator for AWS RDS
3 participants