Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: add some comments #57

Merged
merged 3 commits into from
Jun 17, 2022
Merged

engine: add some comments #57

merged 3 commits into from
Jun 17, 2022

Conversation

SparkYuan
Copy link
Member

@SparkYuan SparkYuan commented Jun 2, 2022 •
edited

  1. re-organization engine pkgs
  2. add some comments in the pkg engine to make codes easier to read

@SparkYuan SparkYuan requested a review from markliby as a code owner June 2, 2022 13:42
@github-actions
Copy link

github-actions bot commented Jun 2, 2022 •
edited

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@SparkYuan SparkYuan self-assigned this Jun 2, 2022
@coveralls
Copy link

coveralls commented Jun 2, 2022 •
edited

Pull Request Test Coverage Report for Build 2515479817

  • 229 of 341 (67.16%) changed or added relevant lines in 13 files are covered.
  • 13 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.9%) to 73.935%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/preview.go 18 19 94.74%
pkg/kusionctl/cmd/destroy/options.go 15 16 93.75%
pkg/engine/operation/parser/delete_resource_parser.go 16 19 84.21%
pkg/kusionctl/cmd/apply/options.go 20 23 86.96%
pkg/engine/operation/diff.go 0 7 0.0%
pkg/engine/operation/parser/parser.go 13 21 61.9%
pkg/engine/operation/models/operation_context.go 0 12 0.0%
pkg/engine/operation/graph/node.go 3 17 17.65%
pkg/engine/operation/parser/spec_parser.go 39 53 73.58%
pkg/engine/operation/graph/resource_node.go 44 93 47.31%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/diff.go 1 0%
pkg/kusionctl/cmd/apply/options.go 6 84.58%
pkg/kusionctl/cmd/destroy/options.go 6 83.5%
Totals Coverage Status
Change from base Build 2508842761: -1.9%
Covered Lines: 3594
Relevant Lines: 4861
💛 - Coveralls

@SparkYuan
Copy link
Member Author

I have read the CLA Document and I hereby sign the CLA

ldxdl
ldxdl reviewed Jun 6, 2022
View reviewed changes
pkg/engine/doc.go Outdated Show resolved Hide resolved
@SparkYuan SparkYuan requested review from a team June 15, 2022 08:11
@SparkYuan SparkYuan force-pushed the dayuan branch 2 times, most recently from fd482fe to 538bbc6 Compare June 16, 2022 06:04
@SparkYuan
Merge remote-tracking branch 'github/main' into refactor/engine
4f3e9c2 
# Conflicts:
#	pkg/engine/operation/models/change.go
#	pkg/engine/operation/models/change_test.go
#	pkg/engine/operation/preview.go
#	pkg/engine/operation/preview_test.go
#	pkg/engine/operation/resource_node.go
#	pkg/engine/operation/types.go
#	pkg/kusionctl/cmd/apply/options.go
#	pkg/kusionctl/cmd/apply/options_test.go
#	pkg/kusionctl/cmd/destroy/options.go
#	pkg/kusionctl/cmd/destroy/options_test.go
ldxdl
ldxdl approved these changes Jun 17, 2022
View reviewed changes
Copy link

@ldxdl ldxdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Two suggestions:

  • continuously optimize the code structure to improve rationality and details.
  • don't change too many files in one PR, split into smaller ones.

elliotxx
elliotxx approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 9078ffa into main Jun 17, 2022
@SparkYuan SparkYuan deleted the dayuan branch June 17, 2022 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chai2010 chai2010 chai2010 left review comments

@elliotxx elliotxx elliotxx approved these changes

@ldxdl ldxdl ldxdl approved these changes

@markliby markliby Awaiting requested review from markliby

Assignees

@SparkYuan SparkYuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SparkYuan @coveralls @chai2010 @elliotxx @ldxdl