Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency and v prefix of releaseVersion from version cmd output #574

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Wenfeng-GAO
Copy link
Contributor

Refs: #408

What type of PR is this?

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #408

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Oct 20, 2023

Pull Request Test Coverage Report for Build 6609792575

  • 81 of 123 (65.85%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.9%) to 75.518%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/version/options.go 70 112 62.5%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/version/options.go 1 64.29%
pkg/engine/operation/watch.go 1 85.93%
Totals Coverage Status
Change from base Build 6586262259: 0.9%
Covered Lines: 6854
Relevant Lines: 9076

💛 - Coveralls

@healthjyk healthjyk self-requested a review October 20, 2023 03:44
healthjyk
healthjyk previously approved these changes Oct 21, 2023
pkg/version/types.go Outdated Show resolved Hide resolved
@healthjyk healthjyk merged commit f671fcb into KusionStack:main Oct 23, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Experience: Kusion version with more accurate output
3 participants