refactor: update secret generator for upcoming external secret #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adohe
force-pushed
the
update_secret_generator
branch
from
eebdb30
to
e3f6161
Compare
Pull Request Test Coverage Report for Build 6939721696
💛 - Coveralls |
adohe
force-pushed
the
update_secret_generator
branch
from
e3f6161
to
86f3be5
Compare
SparkYuan
reviewed
Nov 21, 2023
pkg/generator/appconfiguration/generator/workload/secret/secret_generator.go
Show resolved
Hide resolved
adohe
force-pushed
the
update_secret_generator
branch
from
86f3be5
to
d875967
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
refact secret generator for upcoming external secret type
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: