Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: deprecate old vals based secret store #609

Merged
merged 1 commit into from
Nov 21, 2023
Merged

refactor: deprecate old vals based secret store #609

merged 1 commit into from
Nov 21, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Nov 21, 2023

What type of PR is this?

What this PR does / why we need it:

deprecate old vals based secret store for upcoming secret management

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., design docs, usage docs, etc.:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6938517829

  • 3 of 9 (33.33%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 75.659%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/graph/resource_node.go 3 9 33.33%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/graph/resource_node.go 3 59.06%
Totals Coverage Status
Change from base Build 6927289824: 0.3%
Covered Lines: 6947
Relevant Lines: 9182
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit f59e4e0 into KusionStack:main Nov 21, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2023
@adohe adohe deleted the deprecate_old_secret_store branch January 8, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

Assignees

@SparkYuan SparkYuan

Labels
kind/optimization Code optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adohe @coveralls @SparkYuan