Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace domain model #639

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add domain model of workspace management.

Which issue(s) this PR fixes:

Fixes #617

Special notes for your reviewer:

For the backend config, should be completed later.

@healthjyk
Copy link
Contributor Author

This is an upgrade of #618

@coveralls
Copy link

coveralls commented Nov 30, 2023

Pull Request Test Coverage Report for Build 7044411843

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 19 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.1%) to 74.948%

Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 75.61%
pkg/modules/util.go 9 70.29%
Totals Coverage Status
Change from base Build 7028690290: -0.1%
Covered Lines: 6486
Relevant Lines: 8654

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 0401f38 into KusionStack:main Nov 30, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
@healthjyk healthjyk deleted the workspace-model branch December 27, 2023 03:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: add workspace management domain models
3 participants