Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: runtime apply and detail prompt cancel unexpectly #64

Merged
merged 3 commits into from
Jun 9, 2022
Merged

bugfix: runtime apply and detail prompt cancel unexpectly #64

merged 3 commits into from
Jun 9, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jun 7, 2022 •
edited

issue

fix: #65

action

  • runtime apply should differ create or patch, json merge patch cannot applied to an object which is not existed
  • prompt cycle has a cancel condition, which is triggered every time
  • refactor computing node's action logic
  • use live state and plan state to make a diff report which is consistent with runtime logic

@howieyuen howieyuen force-pushed the fix-runtime branch 4 times, most recently from d4d7245 to ddadabc Compare June 7, 2022 11:21
@howieyuen howieyuen added cli priority/critical-urgent P0, highest priority. Must be actively worked on as someone's top priority right now labels Jun 7, 2022
@coveralls
Copy link

coveralls commented Jun 7, 2022 •
edited

Pull Request Test Coverage Report for Build 2465663045

  • 45 of 58 (77.59%) changed or added relevant lines in 5 files are covered.
  • 55 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.05%) to 75.878%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/resource_node.go 26 39 66.67%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/resource_node.go 24 52.24%
pkg/engine/operation/operation.go 31 36.36%
Totals Coverage Status
Change from base Build 2455186238: -1.05%
Covered Lines: 3693
Relevant Lines: 4867
💛 - Coveralls

@howieyuen howieyuen force-pushed the fix-runtime branch 2 times, most recently from 313c355 to 180aef2 Compare June 8, 2022 12:39
SparkYuan
SparkYuan approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

elliotxx
elliotxx approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 2e51faf into main Jun 9, 2022
@howieyuen howieyuen deleted the fix-runtime branch June 9, 2022 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@elliotxx elliotxx elliotxx approved these changes

@markliby markliby Awaiting requested review from markliby

Assignees
No one assigned
Labels
priority/critical-urgent P0, highest priority. Must be actively worked on as someone's top priority right now
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

internal error when running kusion apply
4 participants
@howieyuen @coveralls @SparkYuan @elliotxx