Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workspace, modules, backends, runtimes management #642

Merged
merged 4 commits into from
Dec 4, 2023
Merged

feat: add workspace, modules, backends, runtimes management #642

merged 4 commits into from
Dec 4, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add workspace management, including the management of runtimes, modules, backends.

Which issue(s) this PR fixes:

Fixes #622

@coveralls
Copy link

coveralls commented Nov 30, 2023 •
edited

Pull Request Test Coverage Report for Build 7087323141

  • 156 of 201 (77.61%) changed or added relevant lines in 2 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 75.008%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/validation.go 88 102 86.27%
pkg/workspace/util.go 68 99 68.69%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/engine/operation/parser/parser.go 6 75.61%
Totals Coverage Status
Change from base Build 7084645551: 0.03%
Covered Lines: 6642
Relevant Lines: 8855
💛 - Coveralls

@adohe adohe self-assigned this Dec 1, 2023
@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Dec 1, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 1, 2023
SparkYuan
SparkYuan reviewed Dec 4, 2023
View reviewed changes
pkg/workspace/util.go Outdated Show resolved Hide resolved
SparkYuan
SparkYuan reviewed Dec 4, 2023
View reviewed changes
pkg/workspace/util.go Outdated Show resolved Hide resolved
SparkYuan
SparkYuan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit dae5fe8 into KusionStack:main Dec 4, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@healthjyk healthjyk deleted the workspace-management branch December 27, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@adohe adohe Awaiting requested review from adohe

Assignees

@adohe adohe

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.

Feat: Add workspace management SDK
4 participants
@healthjyk @coveralls @SparkYuan @adohe