Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename ExternalSecretRef key to name #645

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 3, 2023

What type of PR is this?

What this PR does / why we need it:

rename ExternalSecretRef key to name

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Dec 3, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7076064332

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 75.064%

Totals Coverage Status
Change from base Build 7060299705: 0.3%
Covered Lines: 6496
Relevant Lines: 8654

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 6c23b65 into KusionStack:main Dec 4, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@adohe adohe deleted the rename_external_secret_api branch January 8, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants