Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add workspace CRUD operations #651

Merged
merged 2 commits into from
Dec 5, 2023
Merged

feat: add workspace CRUD operations #651

merged 2 commits into from
Dec 5, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add workspace CURD operation

Which issue(s) this PR fixes:

Fixes #622

@healthjyk healthjyk self-assigned this Dec 5, 2023
@coveralls
Copy link

coveralls commented Dec 5, 2023 •
edited

Pull Request Test Coverage Report for Build 7095860574

  • 85 of 116 (73.28%) changed or added relevant lines in 3 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 74.972%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/util.go 2 6 33.33%
pkg/workspace/operator.go 81 108 75.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/destroy/options.go 7 84.08%
Totals Coverage Status
Change from base Build 7095680498: -0.08%
Covered Lines: 6779
Relevant Lines: 9042
💛 - Coveralls

@SparkYuan SparkYuan changed the title feat: add workspace CURD operation feat: add workspace CRUD operations Dec 5, 2023
SparkYuan
SparkYuan approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 681d5b3 into KusionStack:main Dec 5, 2023
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@healthjyk healthjyk deleted the workspace-operation branch December 27, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@adohe adohe Awaiting requested review from adohe

Assignees

@healthjyk healthjyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: Add workspace management SDK
3 participants
@healthjyk @coveralls @SparkYuan