Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add azure keyvault based secret store #652

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 5, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

add Azure KeyVault based secret store

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/feature Categorizes issue or PR as related to a new feature label Dec 5, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 5, 2023
@coveralls
Copy link

coveralls commented Dec 5, 2023

Pull Request Test Coverage Report for Build 7217092714

  • 88 of 117 (75.21%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 74.511%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/secrets/providers/azure/keyvault/keyvault.go 88 117 75.21%
Totals Coverage Status
Change from base Build 7210876757: 0.2%
Covered Lines: 7238
Relevant Lines: 9714

💛 - Coveralls

@adohe adohe changed the title WIP: add azure keyvault based secret store feat: add azure keyvault based secret store Dec 14, 2023
@adohe adohe merged commit de583e7 into KusionStack:main Dec 21, 2023
6 checks passed
@adohe adohe deleted the add_azure_keyvault_support branch December 21, 2023 05:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@ffforest ffforest linked an issue Dec 28, 2023 that may be closed by this pull request
@ffforest ffforest linked an issue Jan 18, 2024 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: secret generator development Feat: secret management support Azure KeyVault as backend
3 participants