Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mysql/oss/s3 as new backends #662

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add mysql/oss/s3 as new backends

Which issue(s) this PR fixes:

Fixes #647

@coveralls
Copy link

coveralls commented Dec 7, 2023

Pull Request Test Coverage Report for Build 7136729595

  • 61 of 141 (43.26%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 74.477%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/validation.go 61 76 80.26%
pkg/workspace/util.go 0 65 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/workspace/validation.go 1 83.72%
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 7128953341: -0.5%
Covered Lines: 6872
Relevant Lines: 9227

💛 - Coveralls

@healthjyk healthjyk force-pushed the feat-backend branch 2 times, most recently from 432239c to f529fd8 Compare December 7, 2023 12:46
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 2385045 into KusionStack:main Dec 11, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
@healthjyk healthjyk deleted the feat-backend branch December 27, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Update workspace backend config and use the workspace backend config for state
3 participants