Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update workspace util func and fix known bug #668

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

healthjyk
Copy link
Contributor

…ce dir is not hidden folder

What type of PR is this?

/kind feature

What this PR does / why we need it:

  1. add CURD func by default workspace operator;
  2. use inline for the GenericObjectStorageConfig for OssConfig and S3Config;
  3. correct validation for S3Config.

@healthjyk healthjyk self-assigned this Dec 11, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7167478622

  • 4 of 52 (7.69%) changed or added relevant lines in 2 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 74.094%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/validation.go 0 1 0.0%
pkg/workspace/operator.go 4 51 7.84%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/workspace/operator.go 5 51.63%
Totals Coverage Status
Change from base Build 7162380829: -0.4%
Covered Lines: 6870
Relevant Lines: 9272

💛 - Coveralls

@SparkYuan
Copy link
Member

What is the pkg/workspace/testdata/invalid_workspaces_dir/dir_workspace_file/.gitkeep file used for?

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@healthjyk healthjyk removed the request for review from adohe December 12, 2023 06:26
@healthjyk healthjyk merged commit 11807b4 into KusionStack:main Dec 12, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@healthjyk healthjyk deleted the update-workspace-sdk branch December 27, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants