-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: state backend using workspace, and upgrade of state #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
healthjyk
force-pushed
the
state-backend-workspace
branch
from
December 11, 2023 12:51
1c6a5ad
to
04eeaa2
Compare
Pull Request Test Coverage Report for Build 7209460420
💛 - Coveralls |
healthjyk
force-pushed
the
state-backend-workspace
branch
from
December 11, 2023 13:38
04eeaa2
to
5788a11
Compare
SparkYuan
reviewed
Dec 12, 2023
SparkYuan
reviewed
Dec 12, 2023
healthjyk
force-pushed
the
state-backend-workspace
branch
3 times, most recently
from
December 13, 2023 06:52
a6ec36b
to
8cb9d5c
Compare
SparkYuan
reviewed
Dec 14, 2023
healthjyk
force-pushed
the
state-backend-workspace
branch
from
December 14, 2023 13:20
8cb9d5c
to
93a26f8
Compare
SparkYuan
approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
/engine/backend
, use cli flags, environment variables, and workspace backend configs in descending order to generate state storage.cmd/preview
,cmd/apply
andcmd/project
use the newNewStateStorage
;local
backend, and default state file updated tokusion_state.yaml
;db
backend tomysql
, allowpassword
empty;s3
, allowendpoint
empty, default state file updated tokusion_state.yaml
;oss
, default state file updated tokusion_state.yaml
;Backend
inConfiguration
of project, do not support configure backend in project.yaml.Which issue(s) this PR fixes:
Fixes #647