Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update the struct of ModuleConfig #671

Merged
merged 1 commit into from
Dec 13, 2023
Merged

refactor: update the struct of ModuleConfig #671

merged 1 commit into from
Dec 13, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update the struct of ModuleConfig.

@healthjyk healthjyk self-assigned this Dec 12, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7181134073

  • 37 of 38 (97.37%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 74.114%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/validation.go 29 30 96.67%
Files with Coverage Reduction New Missed Lines %
pkg/workspace/validation.go 1 83.61%
pkg/workspace/util.go 2 36.05%
Totals Coverage Status
Change from base Build 7177747000: 0.2%
Covered Lines: 6860
Relevant Lines: 9256
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@healthjyk healthjyk merged commit 3d09a64 into KusionStack:main Dec 13, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@healthjyk healthjyk deleted the module-config branch December 27, 2023 03:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

@SparkYuan SparkYuan Awaiting requested review from SparkYuan

Assignees

@healthjyk healthjyk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@healthjyk @coveralls @liu-hm19