Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update secret store providers implementation #677

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 15, 2023

What type of PR is this?

What this PR does / why we need it:

update secret store provider implementation

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Dec 15, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 15, 2023
@coveralls
Copy link

coveralls commented Dec 15, 2023

Pull Request Test Coverage Report for Build 7220236951

  • 17 of 17 (100.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 74.516%

Files with Coverage Reduction New Missed Lines %
pkg/secrets/providers.go 3 81.25%
Totals Coverage Status
Change from base Build 7210876757: 0.2%
Covered Lines: 7158
Relevant Lines: 9606

💛 - Coveralls

@adohe adohe force-pushed the update_secret_store_providers branch from 99716bb to 2fc48fb Compare December 15, 2023 09:23
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit b65129f into KusionStack:main Dec 18, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@adohe adohe deleted the update_secret_store_providers branch January 8, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants