Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pulumi deplendency, use third_party instead #68

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jun 8, 2022

kusion only use some util funcs of pulumi, we can make a copy of utils, save it in third party.

close: #58

@coveralls
Copy link

coveralls commented Jun 8, 2022

Pull Request Test Coverage Report for Build 2514478108

  • 6 of 21 (28.57%) changed or added relevant lines in 3 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.4%) to 75.399%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/init/options.go 1 3 33.33%
pkg/scaffold/loader.go 1 3 33.33%
pkg/scaffold/external_templates.go 4 15 26.67%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser.go 3 85.19%
pkg/engine/operation/manifest_parser.go 4 70.54%
pkg/kusionctl/cmd/destroy/options.go 7 83.5%
Totals Coverage Status
Change from base Build 2508842761: -0.4%
Covered Lines: 3681
Relevant Lines: 4882

💛 - Coveralls

@elliotxx elliotxx added the kind/optimization Code optimization label Jun 9, 2022
@elliotxx elliotxx added this to the v0.5.0 milestone Jun 9, 2022
@howieyuen howieyuen requested a review from adohe as a code owner June 13, 2022 03:06
@howieyuen howieyuen requested a review from a team June 13, 2022 03:06
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@howieyuen howieyuen enabled auto-merge (squash) June 20, 2022 03:27
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit f36425f into main Jun 20, 2022
@howieyuen howieyuen deleted the del-pulumi branch June 20, 2022 03:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comb dependencies in go.mod
4 participants