Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test for pkg/scaffold/internal #70

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix unit test for pkg/scaffold/internal #70

merged 1 commit into from
Jun 13, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Jun 9, 2022

TestTemplateRepository_Templates

UT read from subdir means to fetch 2 or more templates from pkg/scaffold/internal, now we have only one template, which is not compatible with more templates in the future.

TestCopyTemplateFiles

The flaw of this one is pretty the same as above. Copy templates from src dir to target dir, now src dir contains only one, so it's not compatible with more templates as well.

@howieyuen howieyuen added the area/test Categorizes an issue or PR as relevant to test label Jun 9, 2022
@coveralls
Copy link

coveralls commented Jun 9, 2022

Pull Request Test Coverage Report for Build 2473968440

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 75.837%

Files with Coverage Reduction New Missed Lines %
pkg/scaffold/external_templates.go 2 69.86%
pkg/engine/operation/parser.go 3 85.19%
Totals Coverage Status
Change from base Build 2467368842: -0.06%
Covered Lines: 3691
Relevant Lines: 4867

💛 - Coveralls

@howieyuen howieyuen changed the title fix unit test TestCopyTemplateFiles fix unit test for pkg/scaffold/internal Jun 9, 2022
@elliotxx
Copy link
Contributor

Need to supplement PR description

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 407d461 into main Jun 13, 2022
@howieyuen howieyuen deleted the fix-ut branch June 13, 2022 03:01
@howieyuen howieyuen restored the fix-ut branch June 13, 2022 03:01
@howieyuen howieyuen deleted the fix-ut branch June 13, 2022 03:01
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/test Categorizes an issue or PR as relevant to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants