Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add func of getting specified type from workspace genericConfig #708

Merged
merged 1 commit into from
Dec 22, 2023
Merged

feat: add func of getting specified type from workspace genericConfig #708

merged 1 commit into from
Dec 22, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add func of getting specified type from workspace genericConfig.

@coveralls
Copy link

coveralls commented Dec 20, 2023 •
edited

Pull Request Test Coverage Report for Build 7297126639

  • 54 of 59 (91.53%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.1%) to 74.562%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/util.go 51 56 91.07%
Files with Coverage Reduction New Missed Lines %
pkg/workspace/util.go 1 51.72%
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7289522544: 0.1%
Covered Lines: 7284
Relevant Lines: 9769
💛 - Coveralls

adohe
adohe reviewed Dec 21, 2023
View reviewed changes
pkg/workspace/util.go Outdated Show resolved Hide resolved
pkg/workspace/util.go Outdated Show resolved Hide resolved
pkg/workspace/util.go Show resolved Hide resolved
pkg/workspace/util.go Outdated Show resolved Hide resolved
pkg/workspace/util.go Outdated Show resolved Hide resolved
pkg/workspace/util.go Outdated Show resolved Hide resolved
liu-hm19
liu-hm19 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 1b178f6 into KusionStack:main Dec 22, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@healthjyk healthjyk deleted the retrive_specified_type branch December 27, 2023 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adohe adohe adohe left review comments

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@healthjyk @coveralls @adohe @liu-hm19