Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opsRule supports workspace config #711

Merged
merged 2 commits into from
Dec 22, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

feat: opsRule supports workspace config

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@SparkYuan SparkYuan force-pushed the ops-rule-ws branch 2 times, most recently from c662a17 to 2a9cc14 Compare December 21, 2023 07:22
@coveralls
Copy link

coveralls commented Dec 21, 2023

Pull Request Test Coverage Report for Build 7298323980

  • 23 of 27 (85.19%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 74.634%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/trait/ops_rule_generator.go 10 12 83.33%
pkg/modules/patchers/trait/ops_rule_patcher.go 8 10 80.0%
Totals Coverage Status
Change from base Build 7298250355: -0.02%
Covered Lines: 7341
Relevant Lines: 9836

💛 - Coveralls

@SparkYuan SparkYuan force-pushed the ops-rule-ws branch 3 times, most recently from 86f2213 to 094455e Compare December 22, 2023 09:20
@healthjyk healthjyk merged commit fe2ce94 into KusionStack:main Dec 22, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants