Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use workspace config when build service and job #717

Merged
merged 1 commit into from
Dec 22, 2023
Merged

feat: use workspace config when build service and job #717

merged 1 commit into from
Dec 22, 2023

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Use workspace config when build service and job.

Which issue(s) this PR fixes:

Fixes #666

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7297362260

  • 68 of 80 (85.0%) changed or added relevant lines in 5 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 74.583%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/modules/generators/app_configurations_generator.go 3 5 60.0%
pkg/modules/generators/workload/job_generator.go 7 9 77.78%
pkg/modules/generators/workload/service_generator.go 25 29 86.21%
pkg/modules/generators/workload/workload_generator.go 32 36 88.89%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7297339969: -0.05%
Covered Lines: 7330
Relevant Lines: 9828
💛 - Coveralls

liu-hm19
liu-hm19 approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit 1ef33b8 into KusionStack:main Dec 22, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@healthjyk healthjyk deleted the refacotor-workload-1222 branch December 27, 2023 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liu-hm19 liu-hm19 liu-hm19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat: refactor the workload model according to the new design doc
3 participants
@healthjyk @coveralls @liu-hm19