Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspace cli #718

Merged
merged 1 commit into from
Dec 25, 2023
Merged

Conversation

healthjyk
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

add workspace cli

Which issue(s) this PR fixes:

Fixes #604

@coveralls
Copy link

coveralls commented Dec 22, 2023

Pull Request Test Coverage Report for Build 7320679901

  • 275 of 323 (85.14%) changed or added relevant lines in 14 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 74.99%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/util.go 0 1 0.0%
pkg/cmd/workspace/cmd.go 24 26 92.31%
pkg/cmd/workspace/create/cmd.go 28 30 93.33%
pkg/cmd/workspace/del/cmd.go 27 29 93.1%
pkg/cmd/workspace/del/options.go 19 21 90.48%
pkg/cmd/workspace/show/cmd.go 27 29 93.1%
pkg/cmd/workspace/update/cmd.go 29 31 93.55%
pkg/cmd/workspace/create/options.go 24 28 85.71%
pkg/cmd/workspace/show/options.go 22 26 84.62%
pkg/cmd/workspace/update/options.go 24 28 85.71%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 7320192927: 0.3%
Covered Lines: 7616
Relevant Lines: 10156

💛 - Coveralls

pkg/cmd/cmd.go Show resolved Hide resolved
pkg/cmd/workspace/update/cmd.go Outdated Show resolved Hide resolved
pkg/cmd/workspace/create/cmd.go Show resolved Hide resolved
Copy link
Contributor

@liu-hm19 liu-hm19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liu-hm19 liu-hm19 merged commit a91a525 into KusionStack:main Dec 25, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@healthjyk healthjyk deleted the workload-cli branch December 27, 2023 03:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: add workspace config management commands
3 participants