Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use api types in status and core pkg #719

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 22, 2023

What type of PR is this?

What this PR does / why we need it:

use api types in core and status pkg

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added the kind/optimization Code optimization label Dec 22, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 22, 2023
@adohe adohe force-pushed the use_core_v1_api_types branch 4 times, most recently from f21166c to 0a269b8 Compare December 22, 2023 09:00
@coveralls
Copy link

coveralls commented Dec 22, 2023

Pull Request Test Coverage Report for Build 7298177853

  • 172 of 246 (69.92%) changed or added relevant lines in 43 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.07%) to 74.593%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/builders/kcl/kcl_builder.go 4 5 80.0%
pkg/cmd/build/util.go 3 4 75.0%
pkg/engine/operation/diff.go 0 1 0.0%
pkg/engine/operation/parser/parser.go 7 8 87.5%
pkg/engine/runtime/terraform/tfops/state.go 2 3 66.67%
pkg/modules/generators/accessories/database/aws_rds.go 3 4 75.0%
pkg/modules/generators/app_configurations_generator.go 1 2 50.0%
pkg/modules/generators/ordered_resources_generator.go 5 6 83.33%
pkg/modules/generators/workload/job_generator.go 4 5 80.0%
pkg/cmd/apply/options.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7298149874: -0.07%
Covered Lines: 7331
Relevant Lines: 9828

💛 - Coveralls

healthjyk
healthjyk previously approved these changes Dec 22, 2023
@healthjyk healthjyk merged commit d09fa12 into KusionStack:main Dec 22, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2023
@adohe adohe deleted the use_core_v1_api_types branch January 8, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants