Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not create the kcl.mod.lock file when building config #720

Merged
merged 3 commits into from
Dec 25, 2023

Conversation

SparkYuan
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

do not create the kcl.mod.lock file when building config

Which issue(s) this PR fixes:

Fixes #686

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@coveralls
Copy link

coveralls commented Dec 22, 2023

Pull Request Test Coverage Report for Build 7319802772

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • 216 unchanged lines in 22 files lost coverage.
  • Overall coverage decreased (-0.03%) to 74.601%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/cmd/build/builders/kcl/kcl_builder.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
pkg/cmd/build/builders/appconfig_builder.go 2 76.47%
pkg/modules/generators/namespace_generator.go 3 85.42%
pkg/modules/generators/workload/secret/secret_generator.go 3 93.75%
pkg/modules/patchers/monitoring/monitoring_patcher.go 3 87.76%
pkg/modules/patchers/trait/ops_rule_patcher.go 4 83.33%
pkg/modules/generators/monitoring/monitoring_generator.go 5 75.27%
pkg/modules/generators/trait/ops_rule_generator.go 5 90.57%
pkg/engine/operation/models/operation_context.go 6 0.0%
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7297339969: -0.03%
Covered Lines: 7337
Relevant Lines: 9835

💛 - Coveralls

healthjyk
healthjyk previously approved these changes Dec 22, 2023
go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SparkYuan SparkYuan merged commit 61f7798 into KusionStack:main Dec 25, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Delete kcl.mod.lock in kpm package
4 participants