Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update workspace api type add secret store config #724

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

adohe
Copy link
Contributor

@adohe adohe commented Dec 26, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

update workspace api type add secret store config

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@adohe adohe added kind/feature Categorizes issue or PR as related to a new feature kind/enhancement labels Dec 26, 2023
@adohe adohe added this to the 0.10.0 milestone Dec 26, 2023
@adohe adohe changed the title Workspace api update feat: update workspace api type add secret store config Dec 26, 2023
@coveralls
Copy link

coveralls commented Dec 26, 2023

Pull Request Test Coverage Report for Build 7326367090

  • 48 of 66 (72.73%) changed or added relevant lines in 1 file are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 74.949%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/workspace/validation.go 48 66 72.73%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/cmd/apply/options.go 7 71.94%
Totals Coverage Status
Change from base Build 7321516052: -0.04%
Covered Lines: 7674
Relevant Lines: 10239

💛 - Coveralls

@healthjyk healthjyk merged commit 8dce43b into KusionStack:main Dec 26, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@adohe adohe deleted the workspace_api_update branch January 8, 2024 03:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants