Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new FiledType: MapField and AnyField to indicate map entry and interface{} #73

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

howieyuen
Copy link
Collaborator

ref: #72

This PR mainly to add missing field type for template render engine, especially composite type, eg: array, map and struct.

And I also rename struct field of ProjectTemplate, make it more accurate and consistency with custom params structure.

@howieyuen howieyuen requested a review from a team June 14, 2022 03:24
@howieyuen howieyuen added kind/optimization Code optimization cli labels Jun 14, 2022
@howieyuen howieyuen added this to the v0.5.0 milestone Jun 14, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2492575994

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 75.693%

Totals Coverage Status
Change from base Build 2485761807: 0.04%
Covered Lines: 3684
Relevant Lines: 4867

💛 - Coveralls

Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 6c6b761 into KusionStack:main Jun 15, 2022
@howieyuen howieyuen deleted the field-template branch June 15, 2022 03:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/optimization Code optimization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants